Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CommandHandler avoid endless loop #35
I was testing this on the command line without a framework.
If you check the code the get_class command did return an warning (but no exception), neither did the explode function.
Well another option would be to make sure commands are objects by implementing an empty interface Command. At the moment they can be of any type. The reason I coded it this way is that I think this really needs to be addressed.
Commands have a naming convention. They should express intent in their class name. But the current code doesn't even enforce them to be objects. Is this something you guys agree with or is this open for debate?
I could do a pull request for that one. It's not that much code to fix
Updated pull request.