Add AggregateFactory to the example code #64

Merged
merged 2 commits into from Oct 20, 2014

Conversation

Projects
None yet
3 participants
@mbadolato
Contributor

mbadolato commented Oct 17, 2014

PR #42 changes were not applied to the examples directory, causing breakage of unit tests in /examples

Mark Badolato
Add AggregateFactory to the example code
PR #42 changes were not applied to the examples directory, causing breakage of unit tests in /examples
@wjzijderveld

View changes

examples/event-sourced-domain-with-tests/Invites.php
@@ -105,7 +107,7 @@ class InvitationRepository extends Broadway\EventSourcing\EventSourcingRepositor
{
public function __construct(Broadway\EventStore\EventStoreInterface $eventStore, Broadway\EventHandling\EventBusInterface $eventBus)
{
- parent::__construct($eventStore, $eventBus, 'Invitation');
+ parent::__construct($eventStore, $eventBus, 'Invitation', new PublicConstructorAggregateFactory());

This comment has been minimized.

@wjzijderveld

wjzijderveld Oct 20, 2014

Member

In the examples we use the complete namespace. It is easier to spot where a specific class is when quickly browsing through the examples.

@wjzijderveld

wjzijderveld Oct 20, 2014

Member

In the examples we use the complete namespace. It is easier to spot where a specific class is when quickly browsing through the examples.

@mbadolato

This comment has been minimized.

Show comment
Hide comment
Contributor

mbadolato commented Oct 20, 2014

@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
Member

wjzijderveld commented Oct 20, 2014

👍

fritsjanb added a commit that referenced this pull request Oct 20, 2014

Merge pull request #64 from mbadolato/add_aggregate_root_factory_to_e…
…xample_code

Add AggregateFactory to the example code

@fritsjanb fritsjanb merged commit 633b6f6 into broadway:master Oct 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@fritsjanb

This comment has been minimized.

Show comment
Hide comment
@fritsjanb

fritsjanb Oct 20, 2014

Contributor

👍

Thanks @mbadolato

Contributor

fritsjanb commented Oct 20, 2014

👍

Thanks @mbadolato

@mbadolato mbadolato deleted the mbadolato:add_aggregate_root_factory_to_example_code branch Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment