New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the example InvitesTest #66

Merged
merged 1 commit into from Oct 23, 2014

Conversation

Projects
None yet
3 participants
@mbadolato
Contributor

mbadolato commented Oct 23, 2014

The InvitesTest example used a hardcoded aggregate id of 1 in each
tests, which also corresponds to the default id in the
Broadway\CommandHandling\Testing\Scenario, making it not quite so
obvious as to how to work with the real aggregate id when doing
scenario testing.

This commit changes the InvitesTest to generate a new UUID in each
test and passes it through to Scenario::withAggregateId() to give
a better (more real-world) example of the proper way to use the
Scenario class

Improve the example InvitesTest
The InvitesTest example used a hardcoded aggregate id of 1 in each
tests, which also corresponds to the default id in the
Broadway\CommandHandling\Testing\Scenario, making it not quite so
obvious as to how to work with the real aggregate id when doing
scenario testing.

This commit changes the InvitesTest to generate a new UUID in each
test and passes it through to Scenario::withAggregateId() to give
a better (more real-world) example of the proper way to use the
Scenario class
@mbadolato

This comment has been minimized.

Show comment
Hide comment
@mbadolato

mbadolato Oct 23, 2014

Contributor

Made a mess trying to squash already merged commits in #65 so closed that and cleaned up and resubmitted here

Contributor

mbadolato commented Oct 23, 2014

Made a mess trying to squash already merged commits in #65 so closed that and cleaned up and resubmitted here

@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
@wjzijderveld
Member

wjzijderveld commented Oct 23, 2014

👍

fritsjanb added a commit that referenced this pull request Oct 23, 2014

@fritsjanb fritsjanb merged commit 389e928 into broadway:master Oct 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@fritsjanb

This comment has been minimized.

Show comment
Hide comment
@fritsjanb

fritsjanb Oct 23, 2014

Contributor

👍

Thanks again @mbadolato

Contributor

fritsjanb commented Oct 23, 2014

👍

Thanks again @mbadolato

@mbadolato mbadolato deleted the mbadolato:improve_example_invites_test branch Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment