renamed type hinting to correctly reference DomainEventStreamInterface #70

Merged
merged 1 commit into from Nov 3, 2014

Conversation

Projects
None yet
3 participants
@GazEdge
Contributor

GazEdge commented Oct 30, 2014

Hi All

I have been looking for an open source project to contribute to for sometime as I want to give something back to the community.

This will be my first pull request so I apologies in advance if I have done something incorrectly. Appreciate any guidance or direction :)

+ * Publishes the events from the domain event stream to the listeners.
+ *
+ * @param DomainEventStreamInterface $domainMessages
+ * @return

This comment has been minimized.

@wjzijderveld

wjzijderveld Oct 31, 2014

Member

Please remove the @return and fix the alignment (it shifted to the left)

@wjzijderveld

wjzijderveld Oct 31, 2014

Member

Please remove the @return and fix the alignment (it shifted to the left)

This comment has been minimized.

@GazEdge

GazEdge Oct 31, 2014

Contributor

done

@GazEdge

GazEdge Oct 31, 2014

Contributor

done

@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
@wjzijderveld

wjzijderveld Oct 31, 2014

Member

👍

Can you squash the 2 commits? One of the other maintainers will then review and merge this 😃

Member

wjzijderveld commented Oct 31, 2014

👍

Can you squash the 2 commits? One of the other maintainers will then review and merge this 😃

renamed type hinting to correctly reference DomainEventStreamInterface
renamed type hinting to correctly reference DomainEventStreamInterface
@GazEdge

This comment has been minimized.

Show comment
Hide comment
@GazEdge

GazEdge Oct 31, 2014

Contributor

Done (I think)

Contributor

GazEdge commented Oct 31, 2014

Done (I think)

othillo pushed a commit that referenced this pull request Nov 3, 2014

othillo
Merge pull request #70 from GazEdge/refactor
renamed type hinting to correctly reference DomainEventStreamInterface

@othillo othillo merged commit ecaf8a4 into broadway:master Nov 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@othillo

This comment has been minimized.

Show comment
Hide comment
@othillo

othillo Nov 3, 2014

Member

thank you, @GazEdge!

Member

othillo commented Nov 3, 2014

thank you, @GazEdge!

@GazEdge GazEdge deleted the GazEdge:refactor branch Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment