Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip implementation #51

Closed
wants to merge 1 commit into from
Closed

Zip implementation #51

wants to merge 1 commit into from

Conversation

@epatey
Copy link
Collaborator

epatey commented Aug 31, 2019

No description provided.

@OpenCombineBot

This comment has been minimized.

Copy link

OpenCombineBot commented Aug 31, 2019

Fails
🚫

Sources/OpenCombine/Publishers/Publishers.Zip.swift#L587 - Line should be 90 characters or less: currently 120 characters (line_length)

Generated by 🚫 Danger Swift against aba1743

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #51 into master will decrease coverage by 1.11%.
The diff coverage is 91.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #51      +/-   ##
=========================================
- Coverage   98.02%   96.9%   -1.12%     
=========================================
  Files          44      43       -1     
  Lines        1920    1876      -44     
=========================================
- Hits         1882    1818      -64     
- Misses         38      58      +20
Impacted Files Coverage Δ
...ources/OpenCombine/Publishers/Publishers.Zip.swift 91.37% <91.37%> (ø)
Sources/OpenCombine/Subject.swift 0% <0%> (-100%) ⬇️
...rces/OpenCombine/Publishers/Publishers.Print.swift 95.08% <0%> (-3.28%) ⬇️
.../OpenCombine/Publishers/Publishers.DropWhile.swift 97.05% <0%> (-2.95%) ⬇️
Sources/OpenCombine/AnySubscriber.swift 92.78% <0%> (-0.08%) ⬇️
...es/OpenCombine/Publishers/Publishers.FlatMap.swift
...enCombine/Publishers/Publishers.ReplaceError.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57c878...aba1743. Read the comment docs.

@broadwaylamb broadwaylamb mentioned this pull request Sep 1, 2019
67 of 84 tasks complete
@broadwaylamb broadwaylamb added this to In progress in OpenCombine via automation Sep 1, 2019
}
}

fileprivate final func receivedChildValue(child: ChildSubscription, _ lockedStoreValue: () -> Void)

This comment has been minimized.

Copy link
@OpenCombineBot

OpenCombineBot Sep 2, 2019

  • 🚫 Line should be 90 characters or less: currently 103 characters (line_length)
@broadwaylamb

This comment has been minimized.

Copy link
Owner

broadwaylamb commented Sep 7, 2019

I've just merged #54, you can synchronize with master and remove the allTests ceremony.

@epatey epatey force-pushed the epatey:zip branch from 9cc0614 to aba1743 Sep 13, 2019
case .sendRequestUpstream(let demand):
lock.do { lockedUpstreamSubscriptions()
.filter { $0.childIndex
!= processingValueForChild?.childIndex } }

This comment has been minimized.

Copy link
@OpenCombineBot

OpenCombineBot Sep 13, 2019

  • 🚫 Closure end should have the same indentation as the line that started it. Expected 16, got 65. (closure_end_indentation)
  • 🚫 Closure end should have the same indentation as the line that started it. Expected 20, got 63. (closure_end_indentation)
@broadwaylamb

This comment has been minimized.

Copy link
Owner

broadwaylamb commented Dec 10, 2019

@MaxDesiatov has took over this PR in #109.

OpenCombine automation moved this from In progress to Done Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OpenCombine
  
Done
3 participants
You can’t perform that action at this time.