Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN1.1 OTAA app session key maybe wrong #382

Closed
wwx0715 opened this issue Nov 6, 2019 · 1 comment
Closed

LoRaWAN1.1 OTAA app session key maybe wrong #382

wwx0715 opened this issue Nov 6, 2019 · 1 comment

Comments

@wwx0715
Copy link

@wwx0715 wwx0715 commented Nov 6, 2019

Is this a bug or a feature request?

Maybe a bug

What did you expect?

Use right app session key through OTAA join when using LoRaWAN1.1

What happened?

app session is not right at server(caculate manually according to LoRaWAN spec1.1 and node caculate are same), but all network session keys are all right

What version are your using?

chirpstack-gateway-bridge 3.4.1
chirpstack-network-server 3.4.1
chirpstack-application-server 3.5.1

How can your issue be reproduced?

this problem always exist. just normally join through OTAA

Could you share your log output?

I tried to degug this problem, and found the app session key maybe caculated using appkey 00000000000000000000000000000000.
I tried to fix this problem using bellow patch:

--- a/internal/api/js/join_server.go
+++ b/internal/api/js/join_server.go
@@ -103,6 +103,7 @@ func getHandler(conf config.Config) (http.Handler, error) {
return joinserver.DeviceKeys{
DevEUI: dk.DevEUI,
NwkKey: dk.NwkKey,

  •                          AppKey:    dk.AppKey,
                              JoinNonce: dk.JoinNonce,
                      }, nil
               },
    

please confirm this problem or I misunderstand.

@brocaar brocaar closed this in eb4bf84 Jan 19, 2020
@brocaar

This comment has been minimized.

Copy link
Owner

@brocaar brocaar commented Jan 19, 2020

Thanks for reporting and sorry for the delay. The above commit fixes the issue + adds a test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.