Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link a LocationEvent to one or more UplinkEvents #413

Closed
diversit opened this issue Jan 14, 2020 · 1 comment
Closed

Link a LocationEvent to one or more UplinkEvents #413

diversit opened this issue Jan 14, 2020 · 1 comment

Comments

@diversit
Copy link

@diversit diversit commented Jan 14, 2020

Is this a bug or a feature request?

Feature

What did you expect?

It would be nice to be able to link a LocationEvent to one or more (in case of multi-frame geolocation) UplinkEvents. This would allow to specifically track back which frames caused a geolocation lookup.

Currently an UplinkEvent has 'uplinkID's for each gateway which received the message, but the message itself does not have a unique identifier. If such an identifier could be added, then this identifier could be added to the LocationEvent to indicate which frames caused the geolocation lookup.

What happened?

Currently LocationEvent has no reference to an UplinkEvent and UplinkEvent has no unique identifier.

What version are your using?

3.6.1

@brocaar

This comment has been minimized.

Copy link
Owner

@brocaar brocaar commented Jan 24, 2020

I'm planning to add a uplink_ids field to the location events. I believe that should make it possible to link the location event against the uplink meta-data.

    // Uplink IDs used for geolocation.
    repeated bytes uplink_ids = 7 [json_name = "uplinkIDs"];
brocaar added a commit to brocaar/chirpstack-network-server that referenced this issue Jan 24, 2020
@brocaar brocaar closed this in 424b160 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.