Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: brockboland/pull_request_demo
base: f083be42e4
...
head fork: brockboland/pull_request_demo
compare: af309e63ba
  • 2 commits
  • 1 file changed
  • 0 commit comments
  • 1 contributor
Showing with 11 additions and 1 deletion.
  1. +11 −1 README.md
View
12 README.md
@@ -10,4 +10,14 @@ FAQ
===
Wait, what?
-----------
-Relax, it'll make more sense once the video is up.
+Relax, it'll make more sense once the video is up.
+
+I watched the video and I still don't understand.
+-------------------------------------------------
+Pull requests are a great way for your team to do code review before merging new features or bug fixes back into the primary branch (typically master, often times develop). For any new change, create a new branch from master and commit your changes there, then open a pull request
+
+What if there's already an open issue to which I'd like to attach code?
+------------------------------------------------------------------------
+As far as I can tell, this can't be accomplished through the interface. There's a button to create a pull request for a new branch, but no button to attach a new branch to an existing issue.
+
+This is best accomplished, then, using [hub](https://github.com/defunkt/hub), which adds some extra features to git for use with Github.

No commit comments for this range

Something went wrong with that request. Please try again.