Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 #61

Merged
merged 22 commits into from Jun 21, 2018
Merged

4.0.0 #61

merged 22 commits into from Jun 21, 2018

Conversation

@brockpetrie
Copy link
Owner

@brockpetrie brockpetrie commented Dec 4, 2017

  • Add linter and get code in adherence to Airbnb styleguide (#60)
  • Add UTC filter function (#62)
  • Add Duration filter (#67)
  • Support passing options to calendar filter function (#60)
  • Smarter treatment of numeric inputs: determine if number is in seconds or milliseconds (#69)
brockpetrie added 5 commits Dec 3, 2017
Codebase style
Add UTC conversion
@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented Dec 5, 2017

Do you want me to pick up any of these?

@brockpetrie
Copy link
Owner Author

@brockpetrie brockpetrie commented Dec 5, 2017

I actually have them all done locally, just need to do some final cleanup and add a couple tests!

@pqt
Copy link

@pqt pqt commented Jan 9, 2018

Anything that can be done to help this along? Really looking forward to the UTC filter function in particular, happy to help however needed. @brockpetrie

@blackst0ne
Copy link

@blackst0ne blackst0ne commented Jan 31, 2018

Any update on this?
Waiting for 4.0.0 because of the .utc() support.

brockpetrie added 2 commits Feb 3, 2018
# Conflicts:
#	readme.md
@brockpetrie
Copy link
Owner Author

@brockpetrie brockpetrie commented Feb 3, 2018

Sorry everyone! Work has been a bit nutty, but finally have some time to (hopefully) wrap this up this weekend.

Remaining tasks are testing the new Durations PR (#67), testing the 4.0.0 branch as it currently stands, writing a few additional tests, and adding the documentation for #60 to the readme.

brockpetrie added 8 commits Feb 3, 2018
Smarter numeric input handling
Add Duration filter
@brockpetrie
Copy link
Owner Author

@brockpetrie brockpetrie commented Feb 5, 2018

Alright I think this is ready to go. Could do with a bit of additional testing though!

@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented Feb 5, 2018

Sorry Brock, I didn't have much chance to look at this over the weekend, I will have a good look this morning.

Would you like me to write some additional unit tests if I notice a gap in the coverage?

@molerat619
Copy link

@molerat619 molerat619 commented Mar 5, 2018

Hey, when will this be available? I would love to use these features :)

@rlightner
Copy link

@rlightner rlightner commented Apr 14, 2018

Any idea when you'll actually get this merged in?

@coxta
Copy link

@coxta coxta commented May 15, 2018

Let's get this merged!!!

BrockReece added 2 commits May 16, 2018
@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented May 16, 2018

@brockpetrie
I have taken the liberty of publishing a prerelease for this.
v4.0.0-0 is now be available on NPM

@blackst0ne
Copy link

@blackst0ne blackst0ne commented May 27, 2018

What's the problem to release 4.0?

@purplelady105
Copy link

@purplelady105 purplelady105 commented May 29, 2018

Do we have an ETA on releasing 4.0.0?

@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented May 30, 2018

I think we were trying to get some time to properly test this. I have published a prerelease on to NPM a couple of weeks back, is anyone using it that wouldn't mind giving us some real world feedback?

I have loaded it into this sandbox if anyone wants to have a look.

@scherii
Copy link

@scherii scherii commented May 30, 2018

I've been using the NPM pre-release since the beginning, it works flawlessly. Before, I used this PR manually, which works without problems. Thank you very much for your work, it is highly appreciated!

@blackst0ne
Copy link

@blackst0ne blackst0ne commented May 30, 2018

@BrockReece we've been using the pre-release 4.0 version for a while.
No problem has been raised.

@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented May 31, 2018

@scherii @blackst0ne
Thanks for the feedback.

@brockpetrie I think this is ready to merge in. Shall I do the honours?

@brockpetrie
Copy link
Owner Author

@brockpetrie brockpetrie commented Jun 12, 2018

@BrockReece Definitely! Looks like we have some [hopefully] minor conflicts, but I'll let you resolve those! Thanks dude

@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented Jun 17, 2018

I have resolved these, it might be worth considering something like #87 so we don't break IE support for our existing users though?

4.0.0 bili
@BrockReece BrockReece merged commit c32c5a0 into master Jun 21, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@BrockReece BrockReece deleted the 4.0.0 branch Jun 21, 2018
@BrockReece
Copy link
Collaborator

@BrockReece BrockReece commented Jun 21, 2018

Merged into master and published v4.0.0

@pqt
Copy link

@pqt pqt commented Jun 21, 2018

You're my hero for this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants