Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor levels not word diffed #49

Closed
brodieG opened this issue Jul 29, 2016 · 1 comment
Closed

Factor levels not word diffed #49

brodieG opened this issue Jul 29, 2016 · 1 comment
Labels
Milestone

Comments

@brodieG
Copy link
Owner

brodieG commented Jul 29, 2016

In:

diffPrint(factor(1:100), factor(c(1:99, 101)))

The 101 in the levels is not shown as a different word.

Indirectly reported by Frank

@brodieG brodieG added the bug label Jul 29, 2016
@brodieG brodieG added this to the 0.1.2 milestone Jul 30, 2016
@brodieG
Copy link
Owner Author

brodieG commented Aug 1, 2016

Turns out this happens because in that case there is a difference on the last line of "content", and the factor levels end up in that same hunk, and our selection mechanism for what gets a word diff after the wrap diff is too coarse.

brodieG added a commit that referenced this issue Aug 1, 2016
brodieG added a commit that referenced this issue Aug 1, 2016
@brodieG brodieG closed this as completed in 06e3d4c Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant