Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization Issues #69

Closed
brodieG opened this issue Sep 7, 2016 · 1 comment
Closed

Optimization Issues #69

brodieG opened this issue Sep 7, 2016 · 1 comment
Labels
Milestone

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Sep 7, 2016

The following should not be as slow as it is:

v1 <- 1:1e5
v2 <- c(1e5 + 1, v1[-c(4:7, 1e2, 1e3, 1e4)])
system.time(diffPrint(v1, v2, context=1, format="raw"))
#   user  system elapsed 
#11.760   2.520  14.307 
system.time(ses(as.character(v1), as.character(v2)))
#   user  system elapsed 
#  0.112   0.005   0.116 

Most likely due to alignment.

@brodieG brodieG added the enhancement label Sep 7, 2016
@brodieG brodieG modified the milestones: 0.1.5, 0.1.6 Sep 7, 2016
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Sep 9, 2016

Actually, a big part of this is just the capture.output directly to a vector. The rest is mostly regular expression related things that will be difficult to optimize.

@brodieG brodieG closed this in 434a987 Sep 12, 2016
brodieG added a commit that referenced this issue Sep 12, 2016
Fix #63, Fix #69, Fix #70, Fix #71, Fix #72.
See NEWS for details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.