Skip to content

/ diffobj

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`style` should not silently override other params #72

Closed
brodieG opened this issue Sep 9, 2016 · 0 comments
Closed

`style` should not silently override other params #72

brodieG opened this issue Sep 9, 2016 · 0 comments
Labels
enhancement
Milestone
0.1.5

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Sep 9, 2016

The following should throw some type of warning:

diffPrint(letters, LETTERS, format="ansi8", brightness="dark", color.mode="rgb", style=StyleAnsi256LightYb())

since the style arg completely overrules the others.
@brodieG brodieG added the enhancement label Sep 9, 2016
@brodieG brodieG added this to the 0.1.5 milestone Sep 9, 2016
@brodieG brodieG closed this in d23b557 Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.1.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@brodieG
You can’t perform that action at this time.