Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`rds` feature confused by char vectors containing NAs #82

Closed
brodieG opened this issue Nov 1, 2016 · 1 comment
Closed

`rds` feature confused by char vectors containing NAs #82

brodieG opened this issue Nov 1, 2016 · 1 comment
Labels
Milestone

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Nov 1, 2016

Bug likely in:

if (is.chr.1L(x) && file_test("-f", x) || inherits(x, "connection"))

in get_rds, should be parenthesis around or statement.

@brodieG brodieG added the bug label Nov 1, 2016
@brodieG brodieG added this to the 0.1.6 milestone Nov 1, 2016
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Nov 3, 2016

Can't reproduce this right now, tried with:

diffPrint(c(NA, "hell"), c(letters, NA))

Will have to track down the more complex example. Perhaps this is related:

> diffChr(c(NA, "hell"), c(letters, NA))
Error in if (any(nc_fun(cur.capt) > etc@text.width.half) || any(nc_fun(tar.capt) >  : 
  missing value where TRUE/FALSE needed
@brodieG brodieG added the fixed in dev label Nov 6, 2016
@brodieG brodieG closed this in c625f7b Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.