Skip to content

/ diffobj

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a `fast` Option For `diffChr` #84

Closed
brodieG opened this issue Nov 3, 2016 · 2 comments
Closed

Add a `fast` Option For `diffChr` #84

brodieG opened this issue Nov 3, 2016 · 2 comments
Labels
enhancement fixed in dev
Milestone
0.1.6

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Nov 3, 2016 •
edited

would auto-set all this stuff from vignette:

diffChr(
  v1, v2, word.diff=FALSE, convert.hz.white.space=FALSE,
  ignore.white.space=FALSE
)

Though need to investigate those that really make a difference and benchmark to ses.
@brodieG brodieG added the enhancement label Nov 3, 2016
@brodieG brodieG added this to the 0.1.6 milestone Nov 3, 2016
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Nov 9, 2016

Related to #73
@brodieG brodieG mentioned this issue Nov 9, 2016
Open
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Nov 10, 2016

For now, just optimizing the convert.hz.white.space piece so that the only arg we need to flip is diffChr, further work will be in #73
@brodieG brodieG closed this in aeb7535 Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fixed in dev
Projects
None yet
Milestone
0.1.6
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@brodieG
You can’t perform that action at this time.