Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should zero-width Sequences Be Counted as Zero Width in `substr_ctl`? #56

Closed
brodieG opened this issue Aug 28, 2018 · 0 comments
Closed

Should zero-width Sequences Be Counted as Zero Width in `substr_ctl`? #56

brodieG opened this issue Aug 28, 2018 · 0 comments
Milestone

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Aug 28, 2018

The tension is that ANSI CSI SGR sequences are treated as zero width. Maybe the answer here is to have a substr_sgr that only treats the ANSI CSI SGR sequences as zero width.

Will have to look into how type='chars' trickles into the rest of the code, and potentially adding a conditional into how C0 sequences are counted. The dangerous part here is that will affect everything and we have to make sure we don't accidentally introduce undesired behavior elsewhere.

@brodieG brodieG added the question label Aug 28, 2018
@brodieG brodieG added this to the 0.3.1 milestone Aug 28, 2018
@brodieG brodieG closed this in 52d52e6 Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.