Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation tweaks #51

Closed
wants to merge 1 commit into from
Closed

Documentation tweaks #51

wants to merge 1 commit into from

Conversation

krlmlr
Copy link

@krlmlr krlmlr commented Jul 21, 2018

Originally in #49.

@brodieG
Copy link
Owner

brodieG commented Aug 7, 2018

I'm going to close this issue because the section of the docs that you are tweaking will need to be immediately changed to reflect the issues with R-3.2.0-3.2.1, so it doesn't really make sense to merge this now.

Thank you for proposing the edits.

@brodieG brodieG closed this Aug 7, 2018
@brodieG
Copy link
Owner

brodieG commented Aug 7, 2018

Actually, re-opening for now until I actually make the doc changes.

@brodieG brodieG reopened this Aug 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #51 into development will decrease coverage by 6.63%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #51      +/-   ##
===============================================
- Coverage          100%   93.36%   -6.64%     
===============================================
  Files               24       24              
  Lines             2044     2034      -10     
===============================================
- Hits              2044     1899     -145     
- Misses               0      135     +135
Impacted Files Coverage Δ
R/tohtml.R 33.33% <0%> (-66.67%) ⬇️
R/strip.R 38.46% <0%> (-61.54%) ⬇️
R/has.R 42.85% <0%> (-57.15%) ⬇️
R/nchar.R 45.71% <0%> (-54.29%) ⬇️
R/strwrap.R 56.98% <0%> (-43.02%) ⬇️
R/strtrim.R 76.08% <0%> (-23.92%) ⬇️
R/strsplit.R 79.71% <0%> (-20.29%) ⬇️
R/misc.R 82.85% <0%> (-17.15%) ⬇️
R/substr2.R 87.62% <0%> (-12.38%) ⬇️
R/internal.R 90% <0%> (-10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076145c...5a16154. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants