Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff improvements #161

Closed
brodieG opened this issue Jan 5, 2016 · 2 comments
Closed

diff improvements #161

brodieG opened this issue Jan 5, 2016 · 2 comments

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Jan 5, 2016

Word diff not working fantastic in these cases:

@@ .ref @@
-  [1] "**`1:3` should** be length 5 (is 3)"
@@ .new @@
+  [1] "**should** be length 5 (is 3)"

** added for emphasis since colors not shown. should should not be part of the diff.

@brodieG brodieG added the enhancement label Jan 5, 2016
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Jan 5, 2016

Do we need a version of all.equal like alike that returns the index difference?

  • could save expression to history so all user has to do is hit up and have the object with subsetting expression read to go
  • Need to reconcile issues with first actual diff possibly not being first display diff and ending up really confusing situation where visual diff is showing one error, but the value diff is showing another
@brodieG brodieG mentioned this issue Jan 11, 2016
@brodieG brodieG added this to the 1.1.1 milestone Aug 28, 2016
@brodieG brodieG modified the milestones: 1.1.0, 1.2.0 Sep 28, 2016
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Nov 28, 2016

This is resolved with integration with diffobj

@brodieG brodieG closed this Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.