Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More systematic handling of `library`, `attach`, etc. shimming #166

Closed
brodieG opened this issue Aug 24, 2016 · 1 comment
Closed

More systematic handling of `library`, `attach`, etc. shimming #166

brodieG opened this issue Aug 24, 2016 · 1 comment

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Aug 24, 2016

Seems like those functions change more than anticipated. Breaks in 3.2, and now in 3.3. At a minimum seems like we need reference versions of them for older R versions.

Is there a strategy to work around this issue? How terrible is it to check search path before and after each statement? Obviously we'll miss out on any statements that attach/detach or load/unload within a single statement, but we can only observe the final result after the statement is executed anyway, so is there really a huge advantage to tracking every search path / namespace change? Options?

Actually, the problem is that our special environment that bypasses .GlobalEnv needs to be updated any time library, etc. are called otherwise top level test expressions won't see the newly attached packages.

We could provide our own library, etc functions to try to address this. Should be okay because only top level tests are affected. Any package functions that risk calling library/etc. directly should be relying on NAMESPACE. That said, we add a high risk of difficult to debug problems.

@brodieG brodieG added this to the 1.1.1 milestone Aug 28, 2016
@brodieG brodieG modified the milestones: 1.1.0, 1.2.0 Sep 28, 2016
@brodieG
Copy link
Owner Author

@brodieG brodieG commented Nov 28, 2016

Fixed by switching to a new tracing mechanism that traces at end of those functions.

@brodieG brodieG closed this Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.