Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Output For Errors #168

Closed
brodieG opened this issue Aug 28, 2016 · 1 comment
Closed

Improved Output For Errors #168

brodieG opened this issue Aug 28, 2016 · 1 comment

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Aug 28, 2016

Doesn't make sense to show both value diff and condition diff when in one instance there is an error and in the other there isn't:

> library(ggplot2)
Error in library(ggplot2) : there is no package called ‘ggplot2’
unitizer test fails on value, and conditions mismatches:
*value* mismatch: `.REF` value was not recorded, but `.NEW` value was; they are 
likely different
< .ref                   > .new                 
@@ 1 @@                  @@ 1 @@                
< <object not recorded>  > NULL                 
*conditions* mismatch: condition count mismatch; expected 0 (got 1)
< .REF$conditions                       > .NEW$conditions                     
@@ 1 @@                                 @@ 1,6 @@                             
< Empty condition list                  > Condition list with 1 condition:    
~                                       >   <simpleError in library(ggplot2): 
~                                       >   there is no package called ‘      
~                                       >   ggplot2’>                         
~                                       > You can access conditions directly  
~                                       > (e.g. `.NEW$conditions[[1L]]`).     
Additionally, there are state differences (compare with `diff_state()`).

Also, maybe custom diffPrint methods for condition lists that default to "unified" diffs?

@brodieG
Copy link
Owner Author

@brodieG brodieG commented Sep 25, 2016

Leaning towards just showing the diffs in full no matter what.

@brodieG brodieG closed this Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.