Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize use of `eval_with_capture` #194

Closed
brodieG opened this issue Nov 20, 2016 · 0 comments
Closed

Minimize use of `eval_with_capture` #194

brodieG opened this issue Nov 20, 2016 · 0 comments

Comments

@brodieG
Copy link
Owner

@brodieG brodieG commented Nov 20, 2016

Right now eval_with_capture is used to evaluate test expressions, but also to compare reference to test items. The latter one actually ends up being a substantial portion of the unitizer execution time, but it seems that the actual test comparison should be simpler to run and not require an evaluation environment as complex as the one used for the initial test evaluation. Some of this is out of our desire to allow for custom user comparison functions, but given the cost we may want to think of some other way of handling this.

The relevant code is within testItem.

@brodieG brodieG added the enhancement label Nov 20, 2016
@brodieG brodieG added this to the 1.3.0 milestone Nov 20, 2016
@brodieG brodieG modified the milestones: 1.3.0, 1.5.0 Nov 28, 2016
@brodieG brodieG closed this in 49f9fd7 Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.