Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll some dependencies forward #101

Closed
wants to merge 2 commits into from
Closed

Conversation

@spinda
Copy link
Contributor

spinda commented Jan 8, 2020

  • @glimmer/syntax 0.41.00.45.3
  • jest 23.6.024.9.0
  • jest-junit 9.0.010.0.0
spinda added 2 commits Jan 8, 2020
brodybits added a commit that referenced this pull request Jan 8, 2020
as proposed in prettierx PR #101

Co-authored-by: Michael Smith <michael@spinda.net>
Co-authored-by: Christopher J. Brody <chris@brody.consulting>
@brodybits

This comment has been minimized.

Copy link
Owner

brodybits commented Jan 8, 2020

Thanks @spinda for the contribution.

+1 on updating the Jest dependencies

I am not yet convinced to update @glimmer/syntax for the following reasons:

I would actually like to find a way to drop support for the non-JavaScript parsers in this project, if possible (somehow). The primary purpose of this project is to offer a fork with more options on the JavaScript parser. I have already made typescript an optional, peer dependency and would like to use Babel to start parsing TypeScript at some point in the future.

We can see that updating @glimmer/syntax triggers a breaking change to the handlebars output. At this point I would rather wait for Prettier to deal with this kind of a breaking change, including whatever test update may be needed.

One more minor point is that I would generally favor updating dependencies and devDependencies in separate PRs.

I tried pushing prettierx-update-jest-dependencies branch that just updates the Jest dependencies, and it seems to give us a green build.

I just pushed an update to dev (the default branch) update the Jest dependencies with reference to both your name and this PR number, so you should have the due credit that you deserve.

Thanks again!

@spinda

This comment has been minimized.

Copy link
Contributor Author

spinda commented Jan 8, 2020

Understood. I see you're already dealing with the @glimmer/syntax problem on the prettier side in prettier/prettier#6570.

@spinda spinda closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.