New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user-specified adblock filters #2
Comments
|
For me using ublock origin filter syntax seems most preferable. Moreover, uBO supports adguard filters, that, in my opinion, are the best in coverage ads. It would be nice to realize their potential here. |
|
I am familiar with uBlock origin; uBO does not enable adguard filters by default but uses EasyList+EasyPrivacy+some others, I am going to try to cover the same lists. |
|
Right now the biggest problem I see is that the original NoChromo patch is a very simplified request blocker, it has no support for the rules' options, or for the selectors. Comparing to SWE (I recently could give a look to their commits), they use WebRefiner there, which is quite advanced. To complicate further the picture, Google is developing their own in-house adblocking, which makes it somewhat not a good choice to try to add WebRefiner to latest Chromium codebase: it might be better to just mod Google's own safebrowsing-with-adblocking. So for now I will just maintain the current simple approach to ad blocking, and wait for Google's own adblocker to mature. They'll likely add some external API to check what to block and/or whitelists, which we do not want. |
|
I have added a wiki page to document adblocking engines used in Chromium browsers: https://github.com/bromite/bromite/wiki/AdBlocking |
|
The embedded adblock filters are updated every time Bromite is built for a new Chromium release; since these releases are often enough, I will close this enhancement issue for now. |
|
Reopening this issue because I plan to implement download of adblock filters. This would afterwards allow something like #33. For now I am discarding having a configuration tab, too complex, but we will still have a user preference URL where to fetch the filters from, and baked-in filters as a fallback. |
This comment has been minimized.
This comment has been minimized.
|
Is it possible to implement it as a single text file that can be edited from within bromite. Eg: from a custom URI. |
|
Would be cool to also have the ability to disable third party java scripts and media (like in uBlocks "advanced" mode). |
|
uBO seems to also hybridize UserScript. Refer to their Experimental filter set. Instead of blocking google analytics it replaces it with neutered version for example. More power is better. |
|
As it seems now, it works well though as a maintainer of a hosts file for adblocking, I suggest that it must somehow include a "load hosts file" or something to update the adblocking list instead of making it hardcoded. My scenario hours ago:
|
|
Hi! Because Bromite ships with hard coded adblock filters, every version is identified by the rules it has. In other words, the User-Agent-anonymize.patch doesn't really work without supporting user-specified filters (this issue), thus differing from the release apk. I released a public test page that shows your current build, working for the latest v76 versions and some older ones. You can find it at https://foss-rocks.github.io/bromite-version-check/, repository here. |
|
Yes, I confirm the above. @foss-rocks the identification of version will only be mitigated if the feature described in this issue exists and it is configured to auto-update by default |
|
With |
|
Does Bromite use the API for filtering that Google wants to get rid off in one of the next Chrome (and certainly Chromium) versions? |
It was never used in Bromite, it's an API for extensions. |
|
Sorry, I just have to ask again for me to not misunderstand you: the new v77 way of filtering is a different filtering method than the filtering used by extensions like uBlock and that Google wants to eliminate? |
|
@ouzowtf the new way and the old way are C++ patches which modify directly the browser code. So they are both different than how extensions work. Extensions use code written in Javascript, to name the biggest difference, and they do not run inside the browser itself. |
|
@ouzowtf on this topic: see my comment here: GrapheneOS/Vanadium#10 (comment) The retiring of the extensions API used by adblocker is related to the Network Service, but they are both part of a bigger strategy of tracking requests IMO. |
|
Thanks for this insight! :) |
|
When will there be an easy way to set our own filters? A lack of solid adblock is the only reason why I am not using this Web browser over e.g. Dolphin. It's bad enough the lack of Chrome extension support but given what I understand this browser's goals are that's okay. What's really kind of not okay is that from a privacy point, proper adblock and any similar tracking and element blocking isn't implemented or at least a method of being able to do this myself isn't implemented. We don't need a full tab for customising adblock rules. Just let us set our own filters in an easy to use manner either by allowing us to add/edit our own hosts list or otherwise. This browser already has more than enough features and it's incredibly stable. Having only the bare minimum super obvious ads "kind of" being removed, and none of the tracking or elements that go with it being blocked, just doesn't cut it though. The only reason I keep this app on my phone and keep updating it is in the hopes I see a customisable adblock feature. Thanks for understanding. |
This is an open source project, you are not entitled to ask "when", sorry. |
|
@githubsucks-usegitlab if you want, use Adguard for a while -- it allows you to use custom filter lists. |
|
Is that Kiwi? Anyway, Bromite's main thing is privacy not extensions or customization. I would love to see those things in Bromite but nope, seeing it keeping simple means a lot. |
No, this is a Yandex browser. It has extension support. But he is too sophisticated and not very comfortable. |
Oh, I use Samsung Browser with the Adguard Content Blocker long ago. |
But I want to be on the chrome, but with the ability to install extensions. |
There are a lot of extensions, that improve privacy. But proprietary browsers, like Kiwi and Yandex, are horrible for privacy. |
This comment has been minimized.
This comment has been minimized.
|
This feature is being tested and should be available on next release; I will also think of a way to help users generate the subresource filters file format that Chromium/Bromite need. |
|
Fixed in See also: https://www.bromite.org/custom-filters |
|
Well, its not an easy way. Not at all. :( |
|
I need the sources of |
|
@sevospl in the help page linked in previous comment there is a link to Chromium documentation. It explains how to compile the tools; the source is in the Chromium repository since that help page explains how to build and use them. |
Hey! I've cloned the whole repo, however I'm not familiar with Ninja/GN at all -- I have no idea how to compile this specific tool. Could you help me more excatly, please? |
|
macchrome has built ruleset_converter.exe for Windows: |





This issue composes of multiple parts:
a new tab/UI to manage the adblocking featurewill not implement thisThe projects we could look at are adBlock and uBlock origin and other browsers that implement such functionality.
The text was updated successfully, but these errors were encountered: