Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange three-dot menu #76

Closed
AndhikaWB opened this issue Jun 24, 2018 · 4 comments
Closed

Rearrange three-dot menu #76

AndhikaWB opened this issue Jun 24, 2018 · 4 comments

Comments

@AndhikaWB
Copy link

AndhikaWB commented Jun 24, 2018

I think it's possible for the 'Exit' to be rearranged below 'Enable JavaScript' and 'Enable AdBlock' because it shall to be placed at the end of three-dot menu.

And if possible, it would be great if 'Help & feedback' from the menu be removed, most people will never use it anyway. Sorry for bad English.

EDIT: Added screenshot.
img_20180624_223958

@csagan5
Copy link
Contributor

csagan5 commented Jun 25, 2018

Yeah it looks bad, I will try to rearrange them. Never could get a grasp of how order works.

@AndhikaWB
Copy link
Author

I think it would be good if you can rearrange 'Enable JavaScript' and 'Enable AdBlock' below the 'Desktop site' option, so we will have 3 checkbox es in a row.

I don't know tho.. Depends on how hard the code was written.

@csagan5
Copy link
Contributor

csagan5 commented Jun 27, 2018

@AndhikaWB that's how I implemented them originally in the XML: all close to the Desktop site checkbox.

However since I do not know well this Android menu format it never worked...

Edit: I managed to rearrange them properly now

@csagan5
Copy link
Contributor

csagan5 commented Jun 29, 2018

Fixed in 67.0.3396.101

@csagan5 csagan5 closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants