jclouds clear loginUser separation and somewhat clearer code; see common-usage.md for full description #332

Merged
merged 2 commits into from Oct 3, 2012

1 participant

@ahgittin
Brooklyn Central member

Support loginUser and other loginXxx properties for JcloudsLocations,
where the loginUser is used to login if distinct from the user which is specified;
and the user is created with admin privileges (and root scrambled) assuming it is distinct from the loginUser.
userMetadata can also now be specified from the config file.
Includes JcloudsLocation significant tidy (but oh so much more to do), and documentation.

@aledsage aledsage commented on an outdated diff Oct 2, 2012
.../java/brooklyn/location/basic/SshMachineLocation.java
@@ -90,9 +90,10 @@
/** properties which are passed to ssh */
public static final Collection<String> SSH_PROPS = ImmutableSet.of(
"noStdoutLogging", "noStderrLogging", "logPrefix", "out", "err", "password",
- "keyFiles", "publicKey", "privateKey", "privateKeyPassphrase", "privateKeyFile", "privateKeyData",
- //TODO prefer privateKeyData/privateKeyFile (confusion about whether other holds a file or data)
- "permissions", "sshTries", "env", "allocatePTY");
+ "permissions", "sshTries", "env", "allocatePTY",
+ "privateKeyPassphrase", "privateKeyFile", "privateKeyData",
+ // deprecate these -- prefer privateKeyData/privateKeyFile (confusion about whether other holds a file or data)
@aledsage
Brooklyn Central member
aledsage added a line comment Oct 2, 2012

Is this a TODO about deprecating them, or are they now deprecated? I couldn't see any warnings or javadoc about them, but haven't looked closely yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ahgittin ahgittin Support loginUser and other loginXxx properties for JcloudsLocations,
where the loginUser is used to login if distinct from the user which is specified;
and the user is created with admin privileges (and root scrambled) assuming it is distinct from the loginUser.
userMetadata can also now be specified from the config file.
Includes JcloudsLocation significant tidy (but oh so much more to do), and documentation.
7d4cc83
@ahgittin
Brooklyn Central member

aled, expanded the comment about wanting to deprecate some properties ... hard to warn (we could, but it is in SshjTool and we possibly pass them through for backwards compatibility) -- i think okay just to remove once 0.4.0 is out (or sooner), we've clarified the documentation at least so it refers to the canonical property names

@ahgittin
Brooklyn Central member

aled's comments updated, and tested on lots of systems, including some new features when root password is pre-set on an image and supplied in config. merging.

@ahgittin ahgittin merged commit fdfbfd9 into brooklyncentral:master Oct 3, 2012
@ZaidM ZaidM pushed a commit to ZaidM/brooklyn that referenced this pull request Dec 12, 2014
@grkvlt grkvlt This closes #332
* github/pr/332:
  Add (optional) credentials to dynamic HTTP sensors
4b11fea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment