Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Got AuthResult.OK while invalid token detected function shouldn't return OK #136

Closed
lenoxys opened this issue Apr 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working fixed in next version Fixed in the code of the next release

Comments

@lenoxys
Copy link
Contributor

lenoxys commented Apr 1, 2022

Client version

1.6.6

Node version

16.2.0

Operating System type

Linux

Operating system version

Raspberry

Describe the bug

Helllo,

this.driver.api.authenticate

return AuthResult.OK

while invalid token detected function shouldn't return OK

To reproduce

Have 2 instances of Eufy Security Client
Login on the first
Login on the second with same credentials
Try to fetch devices on the first

Screenshots & Logfiles

ERROR: Status return code 401, invalidate token { status: 401, statusText: 'Unauthorized' }
ERROR: Status return code not 200 { status: 401, statusText: 'Unauthorized' }
AuthResult.OK

Additional context

No response

@bropat
Copy link
Owner

bropat commented Apr 3, 2022

Hi @lenoxys,

I'm slowly working on version 2.0.0 where this bug is already fixed (the HTTPApi class has been partially revised).

@bropat bropat added the fixed in next version Fixed in the code of the next release label Apr 11, 2022
bropat added a commit that referenced this issue Apr 30, 2022
Added support for Video Doorbell Dual (T8203; #141)
Added support for IndoorCam Mini (T8414; #143)
Added continuos recording setting for some supported cameras
Added continuos recording type setting for some supported cameras
Added default angle setting for IndoorCam Mini (T8414)
Added default angle idle time setting for IndoorCam Mini (T8414)
Added notification interval time setting for some supported cameras
Added calibrate command for some supported cameras
Added set default angle command for IndoorCam Mini (T8414
Added set privacy angle command for IndoorCam Mini (T8414)
Added new charging status "solar charging" (value: 4; issue #127)
Fixed issue if device doesn't support P2P communication
Fixed issue #136
Fixed issue #122
@bropat bropat closed this as completed Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version Fixed in the code of the next release
Projects
None yet
Development

No branches or pull requests

2 participants