Skip to content

Trying to fix deprecation warnings in Django 1.3 by adding "prepared" arg #14

Closed
wants to merge 1 commit into from

2 participants

@linked
linked commented Jul 22, 2011

Trying to fix deprecation warnings in Django 1.3 by adding "prepared" argument to all get_db_prep_* methods
Note: I amended 3 method signatures to take a 'prepared=' argument, which defaults to None. Two of the methods use this method (in that it gets proxied to the super-method call), but for TimeZoneField::get_db_prep_save, the value of this param has no effect (I made no changes to actually use the parameter)

Thanks for the plugin, it's a huge help!

@brosner
Owner
brosner commented Nov 11, 2011

I don't see how this is needed. No where in Django 1.3 or dev (future 1.4) does get_db_prep_save take a prepared keyword argument. Can you be more specific?

@linked
linked commented Nov 11, 2011

been a long time since i touched this, i don't recall why it was necessary, but some portion of my stack required it. probably not worth merging to your trunk, i'll just continue using my own branch, thank you!

@linked linked closed this Nov 11, 2011
@brosner
Owner
brosner commented Nov 11, 2011

Ok, sounds good. If there is something you'd like to see fixed be sure to let me know :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.