Permalink
Browse files

PBGitLane: remove functions with NSString arguments

We don't use these, so let's keep the class clean
  • Loading branch information...
1 parent b4c2a4f commit bda90606f261208bd65ba27dfe769351e45139dd @pieter pieter committed Nov 25, 2008
Showing with 5 additions and 29 deletions.
  1. +5 −5 PBGitLane.h
  2. +0 −24 PBGitLane.mm
View
@@ -34,14 +34,14 @@ class PBGitLane {
PBGitLane()
{
d_index = s_colorIndex++;
- //d_sha = NULL;
}
- bool isCommit(git_oid *sha) const;
- bool isCommit(NSString *sha) const;
+ bool PBGitLane::isCommit(git_oid *sha) const
+ {
+ return !git_oid_cmp(&d_sha, sha);
+ }
void setSha(git_oid sha);
- void setSha(NSString *sha);
git_oid const *sha() const
{
@@ -51,4 +51,4 @@ class PBGitLane {
int index() const;
static void resetColors();
-};
+};
View
@@ -24,24 +24,6 @@
int PBGitLane::s_colorIndex = 0;
-static git_oid str_to_oid(NSString *str)
-{
- git_oid oid;
- git_oid_mkstr(&oid, [str UTF8String]);
- return oid;
-}
-
-bool PBGitLane::isCommit(git_oid *sha) const
-{
- return !git_oid_cmp(&d_sha, sha);
-}
-
-bool PBGitLane::isCommit(NSString *sha) const
-{
- git_oid a = str_to_oid(sha);
- return isCommit(&a);
-}
-
int PBGitLane::index() const
{
return d_index;
@@ -52,12 +34,6 @@ static git_oid str_to_oid(NSString *str)
d_sha = sha;
}
-void PBGitLane::setSha(NSString *sha)
-{
- return setSha(str_to_oid(sha));
-}
-
-
void PBGitLane::resetColors()
{
s_colorIndex = 0;

0 comments on commit bda9060

Please sign in to comment.