fix: drop 32-bit architecture support#648
Merged
Merged
Conversation
Chrome is not distributed for Linux 32-bit ARM, which is the only GitHub Actions runner platform with a 32-bit architecture. Supporting it adds dead code paths that can never be exercised, so remove the i686/x32 handling entirely and let unsupported architectures fail with a clear error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ueokande
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome is not distributed for Linux 32-bit ARM, which is the only GitHub Actions runner platform with a 32-bit architecture. The existing i686 code paths could therefore never be exercised in practice, making them dead code that gives false confidence 32-bit is a supported target.
This change removes all 32-bit (i686/x32) handling from the platform detection and the installer platform-string mappings. Unsupported architectures will now fail fast with a clear error.