Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix fs.readFileSync() with 2 args #17

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
Owner

feross commented Feb 24, 2014

Right now this doesn't work:

var txt = fs.readFileSync(__dirname + '/robot.html', { encoding: 'hex' });

With this PR, it now works. Test added, too.

I think your logic on the function test had two bugs and they canceled each other out. (found with the help of @dcposch)

Owner

feross commented Feb 24, 2014

merged in 0.2.2 so closing

@feross feross closed this Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment