Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prelude fixes #2

Merged
merged 3 commits into from Feb 23, 2013

Conversation

Projects
None yet
2 participants
@defunctzombie
Copy link
Contributor

commented Feb 23, 2013

  • easier to manage prelude
  • fix delegation of require loading to parent if not found in child

Yes, the new prelude looks much bigger, but after minification it isn't. Since the user is responsible for minification, we tradeoff maintainability for preminified prelude (which is unmaintainable).

defunctzombie added some commits Feb 23, 2013

load prelude from file use require and toString
Easier to maintain and understand the prelude
client require should respect any parent require
This allows for chaining of require calls to delegate to a parent
require.
fix prelude name lookup for parent
If no id mapped in current scope, call require with original id and it
will call up to parent require if there is one.

@substack substack merged commit 162ae59 into browserify:master Feb 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.