Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for top level transforms and symlinked node modules #1365

Closed

Conversation

@ivantsepp
Copy link

@ivantsepp ivantsepp commented Aug 25, 2015

Adds a failing test with using a transform on top-level files on symlinked node modules.

The test failure is coming from passing in the realpath and module-deps uses this path to determine if the file is top level.

A possible solution is to not pass in the realpath and calculate it instead in module-deps. I think this makes sense as module-deps would want to know the realpath and the resolved path of the file.

@ivantsepp
Copy link
Author

@ivantsepp ivantsepp commented Sep 23, 2015

Any updates on this? Is the test in this PR expected behavior?

@ivantsepp ivantsepp changed the title Add test for top level transforms and symlinked node modules Add failing test for top level transforms and symlinked node modules Sep 23, 2015
@jmm
Copy link
Collaborator

@jmm jmm commented Sep 23, 2015

@ivantsepp Thanks for this! I haven't tried your test (and unfortunately I can't manage to fully "get it" just from the description), but there's some discussion going on in #1386 that you may be interested in.

@zertosh
Copy link
Member

@zertosh zertosh commented Oct 26, 2015

I guess this is fixed by #1392

@zertosh zertosh closed this Oct 26, 2015
@chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Oct 26, 2015

@zertosh Yep, though #1392 hasn't been merged.

@zertosh
Copy link
Member

@zertosh zertosh commented Oct 26, 2015

@chrisirhc cool! Lets let ppl chime in on #1413 since that'll bump browserify to v12, so then #1392 can ride along with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.