Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lazy `message` #47

wants to merge 2 commits into
base: master
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -130,6 +130,9 @@ assert.AssertionError = function AssertionError(options) {
this.expected = options.expected;
this.operator = options.operator;
if (options.message) {
if (options.message instanceof Function) {
This conversation was marked as resolved by zaoqi

This comment has been minimized.

Copy link

ljharb May 11, 2019

instanceof is unreliable and shouldn't be used, what you want here is

Suggested change
if (options.message instanceof Function) {
if (typeof options.message === 'function') {
options.message = options.message();
this.message = options.message;
this.generatedMessage = false;
} else {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.