Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] check existence of `node_modules` #190

Merged

Conversation

Projects
None yet
2 participants
@keithamus
Copy link
Contributor

commented May 9, 2019

This offers a small but useful performance improvement by avoiding unnecessary stat calls.

Fixes #116

[Refactor] check existence of `node_modules`
This offers a small but useful performance improvement by avoiding
unnecessary stat calls.
@ljharb

ljharb approved these changes May 10, 2019

Copy link
Collaborator

left a comment

Thanks, this seems good. Is there perhaps a similar improvement to make in the sync case?

@ljharb ljharb merged commit 4cf8928 into browserify:master May 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ljharb

This comment has been minimized.

Copy link
Collaborator

commented May 10, 2019

Please do note tho; this code is in master for v2, which is unreleased; it'd be great to get a PR into the 1.x branch if there's an improvement to be made in the v1 line.

keithamus added a commit to keithamus/resolve that referenced this pull request May 14, 2019

[refactor] (sync) check existence of node_modules
This brings the same perf improvements as in
4cf8928
(browserify#190)

keithamus added a commit to keithamus/resolve that referenced this pull request May 14, 2019

[New] Add `isDirectory`; use to speed up `node_modules` lookups
This is a backport of 4cf8928 and
fa11d48
(browserify#190 and
browserify#191) to the 1.x branch.

This adds the `isDirectory` option which is needed to drive the
directory lookups.

This offers a small but useful performance improvement by avoiding
unnecessary stat calls.

ljharb added a commit to keithamus/resolve that referenced this pull request May 14, 2019

[refactor] `sync`: check existence of `node_modules`
This brings the same perf improvements as in 4cf8928 / browserify#190

ljharb added a commit to keithamus/resolve that referenced this pull request May 15, 2019

[Performance] use `isDirectory` to speed up `node_modules` lookups
This is a backport of 4cf8928 and
fa11d48 (browserify#190 and browserify#191) to the 1.x branch.

This offers a small but useful performance improvement by avoiding unnecessary stat calls.

ljharb added a commit that referenced this pull request May 15, 2019

v1.11.0
 - [New] Add `isDirectory`; use to speed up `node_modules` lookups (#192, #191, #190)
 - [Tests] up to `node` `v12.2`, `v11.15`, `v6.17`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.