Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] (sync) check existence of node_modules #191

Merged

Conversation

Projects
None yet
2 participants
@keithamus
Copy link
Contributor

commented May 14, 2019

This brings the same perf improvements as in 4cf8928 (#190) but for the sync version

Refs #116

[refactor] `sync`: check existence of `node_modules`
This brings the same perf improvements as in 4cf8928 / #190

keithamus added a commit to keithamus/resolve that referenced this pull request May 14, 2019

[New] Add `isDirectory`; use to speed up `node_modules` lookups
This is a backport of 4cf8928 and
fa11d48
(browserify#190 and
browserify#191) to the 1.x branch.

This adds the `isDirectory` option which is needed to drive the
directory lookups.

This offers a small but useful performance improvement by avoiding
unnecessary stat calls.
@ljharb

ljharb approved these changes May 14, 2019

@ljharb ljharb force-pushed the keithamus:refactor-check-existence-of-node-modules branch from fa11d48 to b7f1805 May 14, 2019

@ljharb ljharb merged commit b7f1805 into browserify:master May 14, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@keithamus keithamus deleted the keithamus:refactor-check-existence-of-node-modules branch May 15, 2019

ljharb added a commit to keithamus/resolve that referenced this pull request May 15, 2019

[Performance] use `isDirectory` to speed up `node_modules` lookups
This is a backport of 4cf8928 and
fa11d48 (browserify#190 and browserify#191) to the 1.x branch.

This offers a small but useful performance improvement by avoiding unnecessary stat calls.

ljharb added a commit that referenced this pull request May 15, 2019

v1.11.0
 - [New] Add `isDirectory`; use to speed up `node_modules` lookups (#192, #191, #190)
 - [Tests] up to `node` `v12.2`, `v11.15`, `v6.17`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.