Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symlink resolve #195

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Diokuz
Copy link

commented Jul 2, 2019

The problem: preserveSymlinks = false does not work in sync mode.

@Diokuz Diokuz force-pushed the Diokuz:master branch from cff4e3d to 1d1778e Jul 2, 2019

@ljharb
Copy link
Collaborator

left a comment

Please provide regression tests.

@Diokuz Diokuz force-pushed the Diokuz:master branch from 1d1778e to 0111032 Jul 3, 2019

@Diokuz

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

I made it, but for unknown reasons, it fails on runner. Locally everything is okay.

@Diokuz

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

Original problem is dependents/node-filing-cabinet#81

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2019

The new test still fails for me locally, on my Mac.

@ljharb ljharb force-pushed the Diokuz:master branch from 0111032 to 19a473d Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.