Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes isCore async check #206

Merged
merged 1 commit into from Jan 6, 2020
Merged

Fixes isCore async check #206

merged 1 commit into from Jan 6, 2020

Conversation

@arcanis
Copy link
Contributor

arcanis commented Jan 6, 2020

There's a slight difference between the sync and async codepaths in that the isCore async check is done in the loadNodeModules callback rather than right before the call.

I'm not sure how to test it though since it has the same behaviour except that packageIterator (from #205) won't be called with core packages.

@ljharb ljharb force-pushed the arcanis:mael/core-fix branch from 457f3cf to dcbd4c5 Jan 6, 2020
@ljharb
ljharb approved these changes Jan 6, 2020
Copy link
Member

ljharb left a comment

Thanks!

@ljharb ljharb merged commit dcbd4c5 into browserify:master Jan 6, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ljharb added a commit that referenced this pull request Jan 6, 2020
ljharb added a commit that referenced this pull request Jan 7, 2020
v1.14.2
 - [Fix] `sync`/`async`: Fixes isCore check (#206)
ljharb added a commit that referenced this pull request Jan 7, 2020
v1.14.2

 - [Fix] `sync`/`async`: Fixes isCore check (#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.