Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Prioritize parent node_module tree in nodeModulesPathsSync before fallback options.paths #8

Merged
merged 1 commit into from Feb 18, 2013

Conversation

Projects
None yet
2 participants
Contributor

rektide commented Jun 22, 2012

Hi James. According to http://nodejs.org/docs/latest/api/all.html#all_loading_from_the_global_folders,
If the NODE_PATH environment variable is set to a colon-delimited list of absolute paths, then node will search those paths for modules if they are not found elsewhere.

Yet the implementation in index.js of the pertinent function, nodeModulesPathsSync, concatenated the list of node_module path combinations to the end of the NODE_PATH isomorphic options.dirs: this seems backwards, no?

@substack substack merged commit 27fa227 into browserify:master Feb 18, 2013

Collaborator

substack commented Feb 18, 2013

Thanks for this! Sorry about the long wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment