Don't muck with source maps if file doesn't match #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source maps were stripped and generated for files that did not contain any modules. But those files were never parsed so their source maps were not initialised correctly. Then the source map merge step would merge the input source map with the uninitialised source map, essentially throwing away all mappings. With this patch the input is passed through entirely if it does not contain any modules, before any source map related checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source maps were stripped and generated for files that did not contain
any modules. But those files were never parsed so their source maps were
not initialised correctly. Then the source map merge step would merge
the input source map with the uninitialised source map, essentially
throwing away all mappings.
With this patch the input is passed through entirely if it does not
contain any modules, before any source map related checks.