Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

Update install.sh to find the right files #114

Closed
wants to merge 1 commit into from

Conversation

Olivia5k
Copy link
Contributor

It seems that the file paths for the manifest and host files have changed and install.sh was not updated to match this.

It seems that the file paths for the manifest and host files have changed and `install.sh` was not updated to match this.
@maximbaz
Copy link
Member

Hey @thiderman, I think the reason install.sh is using chrome-host.json and others is because it is expecting that make static-files has been run on the repo. However, since make static-files is only doing files copy and nothing else, I don't really see the benefit of it, and I like your approach better.

Could you therefore also cleanup the static-files goal from makefile?

@maximbaz maximbaz closed this in cf6622f Sep 14, 2017
@maximbaz
Copy link
Member

I ended up doing this myself as I was editing that file anyway - thanks for the contribution!

maximbaz added a commit that referenced this pull request Sep 15, 2017
This breaks release archives.
Added a describing message on how to install from the source code.

related: #114, #134
@maximbaz
Copy link
Member

FYI the paths were correct and I ended up reverting the change in 45374cd as it broke release archives.

The missing puzzle piece was that when you run ./install.sh from source code, you have to go through the build steps described in CONTRIBUTING.md. Specifically, the step make release will ensure the presence of all the files needed by install.sh.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants