Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Could not connect to server" when incorrect password given #53

Closed
Aaron1011 opened this issue Jun 23, 2013 · 2 comments
Closed

"Could not connect to server" when incorrect password given #53

Aaron1011 opened this issue Jun 23, 2013 · 2 comments

Comments

@Aaron1011
Copy link
Member

@Aaron1011 Aaron1011 commented Jun 23, 2013

If a user provides a correct username (meaning a user with that username exists), but an incorrect password, the game attempts to connect to the server, then displays "Could not connect to server". There should be a nicer message letting the user know that their login information was incorrect.

@brynnb
Copy link
Member

@brynnb brynnb commented Aug 6, 2013

Trying to connect with an account already logged in gives the same error, would be nice for useful error message.

@sergkr
Copy link

@sergkr sergkr commented Sep 1, 2013

I'll try to take this one in my fork. Adding some additional details below.

Besides the generic / unhelpful error message, another (possibly worse) issue is you cannot return back to the login screen if you mistype the password without refreshing the browser. I think rather than navigating away from the login form and launching a non-functional game with broken UI, it would be better to make a separate request to the server to check the username/password. If it is incorrect, then we display a validation error right in the login form.

sergkr added a commit to sergkr/BrowserQuest that referenced this issue Sep 8, 2013
sergkr added a commit to sergkr/BrowserQuest that referenced this issue Sep 8, 2013
sergkr added a commit to sergkr/BrowserQuest that referenced this issue Sep 8, 2013
sergkr added a commit to sergkr/BrowserQuest that referenced this issue Sep 8, 2013
justinclift pushed a commit that referenced this issue Sep 17, 2013
Justin Clift
Fixes issue #53 (show error message when attempting to log in with incorrect password)
@Aaron1011 Aaron1011 closed this Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants