Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for cli.js #133

Merged
merged 1 commit into from Mar 25, 2017
Merged

Tests for cli.js #133

merged 1 commit into from Mar 25, 2017

Conversation

@zhulduz
Copy link
Contributor

@zhulduz zhulduz commented Mar 25, 2017

No description provided.

@ai ai merged commit dc6c78a into browserslist:master Mar 25, 2017
1 check passed
@ai
Copy link
Member

@ai ai commented Mar 25, 2017

Great and fast work 👍.

If you want to learn something new from this task:

  1. spawn.stdout.on('data') is asynchronous callback. It could be executed after a second. So you should return Promise from test.
  2. It is better to wait spawn.stdout.on('close') because big output could call several data events.

Here is a example, how I solved this notices: 1a961a4

@ai
Copy link
Member

@ai ai commented Mar 25, 2017

What is your Twitter and VK accounts for announce?

@zhulduz
Copy link
Contributor Author

@zhulduz zhulduz commented Mar 26, 2017

@ai thanks for the feedback) Now it seems much better.

https://twitter.com/zhankenova, I don't have VK account(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants