Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "since" query #189

Merged
merged 4 commits into from Nov 2, 2017
Merged

New "since" query #189

merged 4 commits into from Nov 2, 2017

Conversation

@ideryabin
Copy link

@ideryabin ideryabin commented Oct 30, 2017

Hi! This adds the new since <year> query to target all versions released since the year specified.
This PR relies on changes made in browserslist/caniuse-lite#11.

P.S. Also, will it be useful to as well add similar until rule for browser versions released until certain year? May be useful for legacy environments.

#145

@ai
Copy link
Member

@ai ai commented Oct 30, 2017

Looks good.

  1. ts variable is not really clear.
  2. Can you use reduce with other QUERIES to have common style.
  3. Error message should be more clear. What year, why incorrect. But, honestly, we could ignore this case, returning empty array is OK for me.
  4. toThrow() must check error message.

@ai
Copy link
Member

@ai ai commented Oct 30, 2017

Awesome. Now we need to wait @ben-eb for caniuse-lite.

@rodweb Feel free to ping he every few days.

@ai
Copy link
Member

@ai ai commented Oct 31, 2017

Now we need to wait next caniuse-lite release (it works automatically, depends on caniuse-db releases)

@ideryabin
Copy link
Author

@ideryabin ideryabin commented Nov 2, 2017

It's just been released: browserslist/caniuse-lite@6b0083d

@ai ai merged commit b014ff8 into browserslist:master Nov 2, 2017
2 checks passed
@ai
Copy link
Member

@ai ai commented Nov 2, 2017

I will release it after my flight

@wopian wopian mentioned this pull request Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants