Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport range queries when mobileToDesktop is true #427
Conversation
This comment has been minimized.
This comment has been minimized.
|
LGTM. Will merge it few hours later. |
This comment has been minimized.
This comment has been minimized.
|
@ai That’s great. I am working on another PR addressing the Android case. |
This comment has been minimized.
This comment has been minimized.
|
Great, I will wait for next PR before the release. |
This comment has been minimized.
This comment has been minimized.
|
Thanks. Released in 4.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JLHwung commentedDec 3, 2019
In this PR we refactor the current implementation of
mobileToDesktopso that the range queries can be resolved against its desktop version.It will help babel-preset-env generate correct sets of plugins for the following query