Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserslist updating warning: remove empty line #612

Merged
merged 5 commits into from Aug 3, 2021
Merged

Conversation

paulvi
Copy link
Contributor

@paulvi paulvi commented Aug 2, 2021

and make 3 lines (every line clearly belonging to browserslist), 2nd, 3rd with " " double spaceindent.

This is to solve ugly output of build when this warning is shown many time and breaks output into unlogical sections with empty lines.

scripts:core:prod:standardEntryPoints: bundle start: "primary"
scripts:core:prod:sentry: Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
scripts:core:prod:disable-console: Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
scripts:core:prod:standardEntryPoints: Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating

Paul Verest added 2 commits Aug 2, 2021
and make 3 lines (every line clearly belonging to browserslist), 2nd, 3rd with "  " double spaceindent.
@ai
Copy link
Member

@ai ai commented Aug 2, 2021

Looks good.

Can you fix ESLint warning (sorry, too busy today)?

@paulvi
Copy link
Contributor Author

@paulvi paulvi commented Aug 3, 2021

check now

Have a nice day

@ai
Copy link
Member

@ai ai commented Aug 3, 2021

Nope, still ESLint warning. This time: Trailing spaces not allowed.

You can test ESLint by your own calling npx eslint .

@ai ai merged commit 3c66f56 into browserslist:main Aug 3, 2021
4 of 5 checks passed
@ai
Copy link
Member

@ai ai commented Aug 3, 2021

Released in 4.16.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants