Updated oldDataWarning function to display how many months old caniuse-lite is.#849
Merged
ai merged 2 commits intobrowserslist:mainfrom Oct 21, 2024
mezhnin:main
Merged
Updated oldDataWarning function to display how many months old caniuse-lite is.#849ai merged 2 commits intobrowserslist:mainfrom mezhnin:main
ai merged 2 commits intobrowserslist:mainfrom
mezhnin:main
Conversation
ai
reviewed
Oct 21, 2024
node.js
Outdated
|
|
||
| console.warn( | ||
| 'Browserslist: caniuse-lite is outdated. Please run:\n' + | ||
| 'Browserslist: caniuse-lite is '+ monthPassed +' month old. Please run:\n' + |
Member
There was a problem hiding this comment.
We need plural form month/months and tests
ai
reviewed
Oct 21, 2024
node.js
Outdated
| @@ -419,8 +429,10 @@ module.exports = { | |||
| var halfYearAgo = Date.now() - TIME_TO_UPDATE_CANIUSE | |||
Member
There was a problem hiding this comment.
Why you need halfYearAgo if you already calculated month?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.