Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.json support #74 #85

Merged
merged 1 commit into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@stepankuzmin
Copy link
Contributor

commented Dec 14, 2016

Add package.json support according to this task.

@ai

This comment has been minimized.

Copy link
Member

commented Dec 14, 2016

Great. Thanks. Will accept it after a dinner.

If you want some feedback: it is dangerous to check just .toThrow(), because maybe you have a issue in new Error code :D. It is a good practice to always check error message by toThrowError(/contains both/)

@stepankuzmin

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2016

Right! Thanks for the review!

@ai ai merged commit 60404fa into browserslist:master Dec 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ai ai referenced this pull request Dec 14, 2016

Closed

Add package.json support #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.