Skip to content

browserslist-autofix: add new return with fixed for CHECKS #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2022

Conversation

SergeyVinogorov
Copy link

Create new return with fixed key for lint function

@ai
Copy link
Member

ai commented Sep 20, 2022

We need also change test to be sure that everything works fine

@ai
Copy link
Member

ai commented Sep 20, 2022

Also, don’t forget to change docs

@SergeyVinogorov
Copy link
Author

about the documentation, did I understand correctly that need to update the changelog or did I miss something?

@ai
Copy link
Member

ai commented Sep 22, 2022

about the documentation, did I understand correctly that need to update the changelog or did I miss something?

You need to add API changes to JS API section of README.md

@ai ai mentioned this pull request Sep 22, 2022
CHANGELOG.md Outdated
@@ -1,6 +1,9 @@
# Change Log
This project adheres to [Semantic Versioning](http://semver.org/).

## 0.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these changes.

I change version only in release commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, understood, pardon!
now i will check how works if set zero queries i think there have bug with new return,
i'll fix it and make new commit again, thank you🤝

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "browserslist-lint",
"version": "0.2.1",
"version": "0.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert it. I change version only in release commit.

@ai
Copy link
Member

ai commented Sep 24, 2022

We also need to change docs:

https://github.com/browserslist/lint#js-api

@SergeyVinogorov
Copy link
Author

Reverted Changelog and version + make changes in docs in js-api

@ai ai merged commit 9f2bb9f into browserslist:main Sep 25, 2022
@ai
Copy link
Member

ai commented Sep 25, 2022

Thanks. Released in 0.3.

@rawr51919 rawr51919 mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants