Skip to content

browserslist-autofix: add new return with fixed for CHECKS - #3

Merged
ai merged 4 commits into
browserslist:mainfrom
SergeyVinogorov:autofix-checks-lint
Sep 25, 2022
Merged

browserslist-autofix: add new return with fixed for CHECKS#3
ai merged 4 commits into
browserslist:mainfrom
SergeyVinogorov:autofix-checks-lint

Conversation

@SergeyVinogorov

Copy link
Copy Markdown

Create new return with fixed key for lint function

@ai

ai commented Sep 20, 2022

Copy link
Copy Markdown
Member

We need also change test to be sure that everything works fine

@ai

ai commented Sep 20, 2022

Copy link
Copy Markdown
Member

Also, don’t forget to change docs

@SergeyVinogorov

Copy link
Copy Markdown
Author

about the documentation, did I understand correctly that need to update the changelog or did I miss something?

Comment thread CHANGELOG.md Outdated
Comment thread package.json Outdated
@ai

ai commented Sep 22, 2022

Copy link
Copy Markdown
Member

about the documentation, did I understand correctly that need to update the changelog or did I miss something?

You need to add API changes to JS API section of README.md

@ai ai mentioned this pull request Sep 22, 2022
Comment thread CHANGELOG.md Outdated
# Change Log
This project adheres to [Semantic Versioning](http://semver.org/).

## 0.3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these changes.

I change version only in release commit.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, understood, pardon!
now i will check how works if set zero queries i think there have bug with new return,
i'll fix it and make new commit again, thank you🤝

Comment thread package.json Outdated
{
"name": "browserslist-lint",
"version": "0.2.1",
"version": "0.3.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert it. I change version only in release commit.

@ai

ai commented Sep 24, 2022

Copy link
Copy Markdown
Member

We also need to change docs:

https://github.com/browserslist/lint#js-api

@SergeyVinogorov

Copy link
Copy Markdown
Author

Reverted Changelog and version + make changes in docs in js-api

@ai
ai merged commit 9f2bb9f into browserslist:main Sep 25, 2022
@ai

ai commented Sep 25, 2022

Copy link
Copy Markdown
Member

Thanks. Released in 0.3.

@rawr51919 rawr51919 mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants