Adding required instrumentation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryart
reviewed
May 6, 2020
| } | ||
|
|
||
| function isUsageReportingEnabled() { | ||
| return process.env.DISABLE_USAGE_REPORTING; |
There was a problem hiding this comment.
Let's document how to opt-out of the usage reporting, please.
Also, it's worth mentioning what all will be collected, and everything is anonymous and cannot be used for identifying a run.
bin/helpers/config.js
Outdated
| @@ -11,5 +11,7 @@ config.rails_host = hosts[config.env].rails_host; | |||
| config.cypress_v1 = `${config.rails_host}/automate/cypress/v1`; | |||
| config.buildUrl = `${config.cypress_v1}/builds/`; | |||
| config.buildStopUrl = `${config.cypress_v1}/builds/stop/`; | |||
| config.usageReportingUrl = `http://127.0.0.1:8000/send_event_cy_internal`; | |||
There was a problem hiding this comment.
What http://127.0.0.1:8000 points to?
There was a problem hiding this comment.
Will point to the endpoint where data will be sent. Will update this before merging
SagarGaniga
reviewed
May 7, 2020
srebs
reviewed
May 13, 2020
| } | ||
|
|
||
| exports.getUserAgent = () => { | ||
| return `BStack-Cypress-CLI/1.x (${os.arch()}/${os.platform()}/${os.release()})`; |
There was a problem hiding this comment.
@nagpalkaran95 Can we get the exact version of the CLI?
Like BStack-Cypress-CLI/<full_version> (${os.arch()}/${os.platform()}/${os.release()})?
suryart
reviewed
May 15, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "browserstack-cypress-cli", | |||
| "version": "1.1.0", | |||
| "version": "1.1.3", | |||
There was a problem hiding this comment.
This is handled during the package publishing, not needed.
suryart
previously approved these changes
May 15, 2020
…-cli into CYP_123_instrumentation
suryart
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
PR Tasks
used, system details and errors that users get so that we can improve the way
users run their Cypress tests on BrowserStack.
browserstack.jsonis an invalid json