From b97d375023df2f6d68aea8062dabe841e1c716e2 Mon Sep 17 00:00:00 2001 From: Vibhaj Rajan Date: Sun, 3 Jul 2016 23:50:12 +0530 Subject: [PATCH 1/2] fixes stop warning --- lib/Local.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Local.php b/lib/Local.php index 1c3f961..0459f85 100644 --- a/lib/Local.php +++ b/lib/Local.php @@ -113,8 +113,10 @@ public function start($arguments) { } public function stop() { + if(!$this->pid) return; $call = $this->stop_command(); shell_exec("$call"); + $this->pid = null; } public function start_command() { From 1622d2c532af17faf3652d470ce3d372cbc6db99 Mon Sep 17 00:00:00 2001 From: Vibhaj Rajan Date: Mon, 4 Jul 2016 00:11:59 +0530 Subject: [PATCH 2/2] use default property values to avoid notice warnings --- lib/Local.php | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/Local.php b/lib/Local.php index 0459f85..2e6a1d2 100644 --- a/lib/Local.php +++ b/lib/Local.php @@ -16,6 +16,21 @@ public function __construct() { $this->key = getenv("BROWSERSTACK_ACCESS_KEY"); $this->logfile = getcwd() . "/local.log"; $this->user_args = array(); + $this->binary_path = ""; + $this->folder_flag = ""; + $this->folder_path = ""; + $this->force_local_flag = ""; + $this->local_identifier_flag = ""; + $this->only_flag = ""; + $this->only_automate_flag = ""; + $this->proxy_host = ""; + $this->proxy_port = ""; + $this->proxy_user = ""; + $this->proxy_pass = ""; + $this->force_proxy_flag = ""; + $this->force_flag = ""; + $this->verbose_flag = ""; + $this->hosts = ""; } public function __destruct() {