From 9cddfbbf736677da248c834c0cf01aac7ad0f803 Mon Sep 17 00:00:00 2001 From: AdityaHirapara Date: Thu, 2 Feb 2023 13:00:47 +0530 Subject: [PATCH 1/2] Fix stop API --- lib/browserstack/local.rb | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/browserstack/local.rb b/lib/browserstack/local.rb index 32bc89c..91c8f34 100644 --- a/lib/browserstack/local.rb +++ b/lib/browserstack/local.rb @@ -10,7 +10,7 @@ class Local def initialize(key = ENV["BROWSERSTACK_ACCESS_KEY"]) @key = key @user_arguments = [] - @logfile = File.join(Dir.pwd, "local.log") + @logfile = File.join(Dir.pwd, "locl.log") @is_windows = RbConfig::CONFIG['host_os'].match(/mswin|msys|mingw|cygwin|bccwin|wince|emc|win32/) @exec = @is_windows ? "call" : "exec"; end @@ -150,11 +150,16 @@ def start_command_args end def stop_command - "#{@binary_path} -d stop #{@local_identifier_flag}".strip + if @local_identifier_flag + return "#{@binary_path} -d stop -localIdentifier #{@local_identifier_flag}".strip + else + return "#{@binary_path} -d stop".strip + end end def stop_command_args - args = ["#{@binary_path}", "-d", "stop", "#{@local_identifier_flag}"] + args = ["#{@binary_path}", "-d", "stop"] + args += ["-localIdentifier", "#{@local_identifier_flag}"] if @local_identifier_flag args = args.select {|a| a.to_s != "" } args.push(:err => [:child, :out]) args From ae4228ee58a8e8ea1d69f5dab0c8f66f6c709738 Mon Sep 17 00:00:00 2001 From: AdityaHirapara Date: Thu, 2 Feb 2023 13:06:54 +0530 Subject: [PATCH 2/2] Remove unnecessary change --- lib/browserstack/local.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/browserstack/local.rb b/lib/browserstack/local.rb index 91c8f34..889a024 100644 --- a/lib/browserstack/local.rb +++ b/lib/browserstack/local.rb @@ -10,7 +10,7 @@ class Local def initialize(key = ENV["BROWSERSTACK_ACCESS_KEY"]) @key = key @user_arguments = [] - @logfile = File.join(Dir.pwd, "locl.log") + @logfile = File.join(Dir.pwd, "local.log") @is_windows = RbConfig::CONFIG['host_os'].match(/mswin|msys|mingw|cygwin|bccwin|wince|emc|win32/) @exec = @is_windows ? "call" : "exec"; end